Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove c-style conversion for vibrantView #29724

Merged
merged 1 commit into from
Jun 16, 2021
Merged

chore: remove c-style conversion for vibrantView #29724

merged 1 commit into from
Jun 16, 2021

Conversation

zcbenz
Copy link
Member

@zcbenz zcbenz commented Jun 16, 2021

Description of Change

Remove the c-style type conversions when using and setting [window vibrantView].

Release Notes

Notes: none

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jun 16, 2021
@MarshallOfSound MarshallOfSound merged commit 330c3bc into main Jun 16, 2021
@MarshallOfSound MarshallOfSound deleted the remove-c-style-convrt branch June 16, 2021 17:13
@release-clerk
Copy link

release-clerk bot commented Jun 16, 2021

No Release Notes

BlackHole1 pushed a commit to BlackHole1/electron that referenced this pull request Aug 30, 2021
@zcbenz @BlackHole1
chore: remove c-style conversion for vibrantView (electron#29724)
bd8bda0
codebytere pushed a commit that referenced this pull request Sep 27, 2021
@zcbenz @codebytere
chore: remove c-style conversion for vibrantView (#29724)
53f15ab
@codebytere codebytere mentioned this pull request Sep 27, 2021
Merged
codebytere pushed a commit that referenced this pull request Sep 27, 2021
@zcbenz @codebytere
chore: remove c-style conversion for vibrantView (#29724)
f5d30b2
@codebytere codebytere mentioned this pull request Sep 27, 2021
Merged
codebytere added a commit that referenced this pull request Sep 29, 2021
@codebytere @zcbenz @dsanders11
fix: ensure set vibrancy with invalid value is a no-op (#31162)
4831aa5 
* chore: remove c-style conversion for vibrantView (#29724)

* fix: ensure set vibrancy with invalid value is a no-op (#29795)

Co-authored-by: Cheng Zhao <zcbenz@gmail.com>
Co-authored-by: David Sanders <dsanders11@ucsbalum.com>
jkleinsc pushed a commit that referenced this pull request Sep 29, 2021
@codebytere @zcbenz @dsanders11
fix: ensure set vibrancy with invalid value is a no-op (#31163)
4bd655a 
* chore: remove c-style conversion for vibrantView (#29724)

* fix: ensure set vibrancy with invalid value is a no-op (#29795)

Co-authored-by: Cheng Zhao <zcbenz@gmail.com>
Co-authored-by: David Sanders <dsanders11@ucsbalum.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepak1556 deepak1556 deepak1556 approved these changes

@codebytere codebytere codebytere approved these changes

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

Assignees
No one assigned
Labels
new-pr 🌱 PR opened in the last 24 hours no-backport semver/none
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@zcbenz @deepak1556 @codebytere @MarshallOfSound